Fix a few regen every 4 seconds mods #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Oct 2, 2023
Regisle
added a commit
to Regisle/PathOfBuilding
that referenced
this pull request
Oct 12, 2023
* fix mod parser second parameter error * madcache
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* fix mod parser second parameter error * madcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6774
The function in modparser doubles up the first match, so
function(interval, percent, duration)is reallyfunction(interval, interval, percent)and should instead be written asfunction(interval, _, percent, duration)This causes it to use the interval again as the percent value
I also checked the rest of the file and there was only one other error with the first value being a number, I did not look to see if there were any functions with an invalid non-number second param