Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix added cooldown and added cast time not working correctly #6728

Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Sep 21, 2023

Description of the problem being solved:

Fixes #6766
Fixes Socketed Projectile Spells have +4 seconds to Cooldown from Black Zenith not working for triggers.

Fixes added cool down not working in general.

Replaces the extra icdr formula again to better handle partially affected cool down pools.

Fixes added cast time being added to cooldown of triggered skill, not the trigger cd.

Cleans breakdown building for trigger rate cap.

Uses following assumptions on how the interactions work.

  • Added cast time is affected by icdr (Tested)
  • Added cooldown is affected by icdr (Tested)
  • added cast time is added to the triggers cooldown but only for the skill that adds the cast time. effCD = max(trggeredCd + added, triggerCD + addedCastTime) (Tested)
  • If there are multiple skills linked to a trigger with one of the skills that add cast time to trigger cd when triggered only the cd for that skill is affected.
  • Added cast time to cooldown when linked to Cwc adds cooldown to a base of 0.

This pr could use some more testing
Test build:
https://pobb.in/ldnfTTLWFNee

@Paliak Paliak force-pushed the addedCooldownSupport branch from 48fd064 to 39c6b61 Compare September 21, 2023 17:02
@Paliak Paliak added the bug: calculation Numerical differences label Sep 21, 2023
@Paliak Paliak marked this pull request as ready for review September 23, 2023 12:03
@Paliak Paliak marked this pull request as draft September 30, 2023 18:56
@Paliak Paliak force-pushed the addedCooldownSupport branch from 68e1f79 to f5f7767 Compare October 2, 2023 01:54
@Paliak Paliak changed the title Fix added cooldown not working for triggers Fix added cooldown and added cast time not working correctly Oct 2, 2023
@Paliak Paliak marked this pull request as ready for review December 31, 2023 12:12
@LocalIdentity LocalIdentity merged commit 8807b61 into PathOfBuildingCommunity:dev Jan 23, 2024
@Paliak Paliak deleted the addedCooldownSupport branch January 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hexblast/Lightning Conduit Cooldown is Incorrectly Calculated when Triggered
2 participants