Stop reordering gems on import #6727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
added
bug: calculation
Paliak
force-pushed
the
stopReorderingGemsOnImport
branch
from
26424dd to
129a9a0
Compare
|
I'd like 'FIX: only disable if item is Dialla's' as it would be the least disruptive ty |
LocalIdentity
approved these changes
Sep 25, 2023
3 tasks
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* FIX: stop reordering gems on import * FIX: only disable if item is dialla's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6721
Description of the problem being solved:
Currently imported gems are sorted on import. Putting skill gems at the top and support gems at the bottom. This reordering causes issues with importing builds that use Dialla's Malefaction where the order of gems matters.
This behavior seems to have been implemented a long time ago in 0b2912b#diff-c5b45cc2adeffbfd2d3f81625693c14819ecf7b1b5d5f4a6cd8a1bef1b5d340cR443
I assume this was a way to fix #4886 and #6707 but may not be necessary any more.