Cap Doom Blast expiration mode and use charge based calcs for skills that ignore tick rate #6720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
changed the title
1 task
LocalIdentity
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6492 (comment) implements #7143
Description of the problem being solved:
At 100% reduced curse duration Doom Blast expiration mode should behave like curse replacement mode since the curse will instantly expire.
Doom blast modes expiration and replacement modes did not allow for curse overlaps. This pr changes the config logic to show the config option when applicable.
Doom Blast expiration and replacement modes used simulation based calculations instead of charge based ones causing unexpected tick rounding during simulation. This pr makes all skills that are the only skill in the current trigger group and ignore server tick rate to use charge based calcs to avoid tick rounding.
This pr also implements hexvlast replacement mode for doom blast which uses the inverse of the sum of fastest hexblast and triggering curse cast time.