Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively process ExtraJewelFunc mods #6716

Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Sep 19, 2023

Fixes #6667

Description of the problem being solved:

Due to the way trees interact with jewels ExtraJewelFuncs are added to modDB after jewels are processed. This pr fixes this by recursively calling initEnv again if ExtraJewelFunc were found. Depth is limited to 1.

Steps taken to verify a working solution:

  • Verified the build in the linked issue works correctly.

@Paliak Paliak added the bug: calculation Numerical differences label Sep 19, 2023
@LocalIdentity LocalIdentity merged commit 51fa4e0 into PathOfBuildingCommunity:dev Dec 5, 2023
@Paliak Paliak deleted the recursiveExtraJewelFunc branch January 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbidden Flesh and Flame (Ngahamu, Flame's Advance) Not Applying outside of Chieftain
2 participants