Fix Divergent Arcane Cloak #6695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divergent Arcane Cloak was scaling the added damage by a per stat instead of a percentage stat. This adds support for using a multiplier variable in place of the percentage value. Also did some testing in game and Arcane Cloak and other similar effects appear to round up the final value so changed that logic too
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
Divergent Arcane Cloak was scaling the added damage by a per stat instead of a percentage stat. This adds support for using a multiplier variable in place of the percentage value. Also did some testing in game and Arcane Cloak and other similar effects appear to round up the final value so changed that logic too Co-authored-by: LocalIdentity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6688
Description of the problem being solved:
Divergent Arcane Cloak was scaling the added damage by a per stat instead of a percentage stat.
This supports using a multiplier variable in place of the percentage value.
I also did some testing in-game and Arcane Cloak and other similar effects appear to round up the final value so I changed that logic too
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/uW97FHR2LA7u
Before screenshot:
After screenshot: