Use HitSpeed as source rate if avilable #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Sep 20, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* FIX: use HitSpeed as source rate if avilable * FIX: use HitSpeed for kitava
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue mentioned on Reddit
Description of the problem being solved:
TotalDPS uses HitSpeed if available. It would probably make sense for triggers to do the same.
PathOfBuilding/src/Modules/CalcOffence.lua
Line 3128 in 31c0990
This may break some interactions but seems to work correctly for Static Strike and Kitava's Thirst.