Another attempt at correct Doom Blast calculations #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
LocalIdentity
approved these changes
Sep 14, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
…munity#6676) * FIX: misc fulldps issues * FIX: cleanup dead code * FIX: doom blast calcs * FIX: spellcheck * FIX: use curse cast rate in curse replacement mode * FIX: apply min mod on source rate * FIX: move Doom Blast source config to eff dps * FIX: modify Doom Blast to better match spreadsheet https://docs.google.com/spreadsheets/d/1J-yVLmDhKqKNE8QecsPnZgNR2TDGDm41f-1tdC_BxQA/edit#gid=1230763965 * FIX: make vixen's mode defualt * FIX: move doom blast options to skill options * Move to alphabetical order * FIX: another attempt at correctly implementing doom blast * FIX: remove duplicate warn * FIX: implement the suggested formula * FIX: incorrect matching if doom blast not coming from a gem * Revert "FIX: implement the suggested formula" This reverts commit e65e1f5. --------- Co-authored-by: LocalIdentity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6481
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/gF8sKhHrauwf
Before screenshot:
After screenshot: