Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unicode input for PoeCharm #6669

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Lancej
Copy link
Contributor

@Lancej Lancej commented Sep 13, 2023

Fixes #6634.

Description of the problem being solved:

Allow Unicode input in EditControls when running under PoeCharm. Added a DetectUnicodeSupport function that uses DrawStringWidth to detect if running under PoeCharm and if so changes the default input filter on EditControl.

I couldn't figure out how to test Unicode input in PoeCharm, even the file boxes it should already work in didn't work for me when I switched Windows languages to try it. Maybe someone that knows more about PoeCharm can test.

Steps taken to verify a working solution:

  • Tested normal PoB still filters Unicode on those controls
  • Tested DetectUnicodeSupport works in PoB and PoeCharm

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Sep 13, 2023
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty hard for any of the core developers to test, but it's clean enough I'm fine putting it in for those who need it. Just need to make a note to remove it if we ever get around to supporting Unicode ourselves.

@Wires77 Wires77 merged commit de2e966 into PathOfBuildingCommunity:dev Sep 13, 2023
@CryAngel1970
Copy link

I tested the newly added function by applying it to the source code on my computer.

Korean input is working well. thank you.

@ZdDroid
Copy link

ZdDroid commented Sep 13, 2023

PoeCharm input text use the UTF8 codec,The ASCII encoding range is 21-122(ANSIC WIKI), anything beyond this encoding range can be regarded as UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering Unicode in Manae Item Sets and Manage Passive Trees
5 participants