Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove triggerDuration from Tawhoa's cooldown calculation #6665

Merged

Conversation

Dogist
Copy link
Contributor

@Dogist Dogist commented Sep 12, 2023

Fixes #6664 .

Description of the problem being solved:

When calculating the Trigger Rate Cap of Tawhoa's Chosen the duration was added to the cooldown, but this behavior has changed in the game with the current Version (3.22).

Steps taken to verify a working solution:

  • The Trigger Rate Cap does not add the Duration of the Skill to the cooldown
  • The Skill Trigger Rate and the DPS of Tawhoa's Chosen is calculated accordingly.

Link to a build that showcases this PR:

https://pobb.in/MkLqsOqQ4KPt

Before screenshot:

image

After screenshot:

image

Also removed the corresponding line in the calcs-breakdown.
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Sep 13, 2023
@LocalIdentity LocalIdentity merged commit 91baec7 into PathOfBuildingCommunity:dev Sep 13, 2023
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tawhoa's Chosen incorrectly adds duration to cooldown
2 participants