Add option to disable JIT #6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be better to have people from that issue copy the Main.lua from this branch directly if they're at all technical. |
Wires77
approved these changes
Sep 13, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* Add option to disable JIT * Revert GUI option * Add --no-jit command line option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
PoB runs very slow for some people as described in #6287. This adds a "--no-jit" command line option to disable JIT that might help with some of these issues. Can remove the option if it ends up not being useful.
Turning off JIT doesn't seem to hurt speed much. I tried "Show Node Power" and it took 23 seconds with JIT and 25 seconds without even with letting JIT have some warmup runs first.
Steps taken to verify a working solution:
Edit: Removed GUI option, replaced with command line option "--no-jit"