Add a remove account button to ImportTab #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrazieJester
changed the title
LocalIdentity
approved these changes
Sep 11, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* add remove account button to ImportTab * update based on feedback, change button to X next to account dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
I often help people optimize and fix problems with their builds, and most of the time only want to import their account once. This has led to me having a large list of account names that I had no intention of importing again in the future. I know I can remove them manually from the settings.xml file, though I figured this might be a nice feature since this is a more convenient method, and some might not know to do that,
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://github.com/CrazieJester/PathOfBuilding
Before screenshot:
After screenshot:
And after clicking the X button with CrazieJester selected