Reduce EstimatePlayerProgress memory usage #6631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce OnFrame memory allocation from about 4.5 MB/s to 0.1 MB/s when PoB is active and on tree tab.
Description of the problem being solved:
EstimatePlayerProgress is called many times per frame because it's used for the width of a control several other controls anchor off of. In the function a local table is created which allocates over 4 MB/s because of how often the function is called. The memory does eventually get garbage collected but this is extra work that isn't needed.
Moved the table to outside the function and did some other minor refactoring.
Steps taken to verify a working solution:
Before/After with PoB window active:
