Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display AoE values as metres #6624

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Display AoE values as metres #6624

merged 1 commit into from
Sep 9, 2023

Conversation

LocalIdentity
Copy link
Contributor

Converts all output breakdowns of units to instead use metres
Adds support for the new mod parsings so they work correctly
I decided on creating variables that just convert the final value for the output to the calcs / sidebar so all the internal calculations still use units. I made sure that everything still used units so if we want to switch everything to metres it should be quite clear
Added support for the stat on Fireball that gains radius over range

Converts all output breakdowns of units to instead use metres
Adds support for the new mod parsings so they work correctly
I decided on creating variables that just convert the final value for the output to the calcs / sidebar so all the internal calculations still use units. I made sure that everything still used units so if we want to switch everything to metres it should be quite clear
Added support for the stat on Fireball that gains radius over range
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Sep 9, 2023
@LocalIdentity LocalIdentity merged commit 0476171 into dev Sep 9, 2023
@LocalIdentity LocalIdentity deleted the add_metres-conversion branch September 9, 2023 00:50
@Botolf1
Copy link

Botolf1 commented Sep 23, 2023

A slight thing the calculation seems to be off when looking at the picture in clacs setting it is treating 1 meter as 5 units and not 10 as it should be

sorry for posting here just felt it was better than opening a new issue on it

image

wiki page for reference https://www.poewiki.net/wiki/Distance

@LocalIdentity
Copy link
Contributor Author

A slight thing the calculation seems to be off when looking at the picture in clacs setting it is treating 1 meter as 5 units and not 10 as it should be

sorry for posting here just felt it was better than opening a new issue on it

image

wiki page for reference https://www.poewiki.net/wiki/Distance

The picture in PoB is correct. Each line is 10 units (1m) while the wiki one is much denser and has lines every 5 units (0.5m)

@Botolf1
Copy link

Botolf1 commented Sep 26, 2023

right my bad just looked off when I was comparing it to in-game RF might just be a trick of the mind

shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
Converts all output breakdowns of units to instead use metres
Adds support for the new mod parsings so they work correctly
I decided on creating variables that just convert the final value for the output to the calcs / sidebar so all the internal calculations still use units. I made sure that everything still used units so if we want to switch everything to metres it should be quite clear
Added support for the stat on Fireball that gains radius over range

Co-authored-by: LocalIdentity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants