Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trauma Rate doubling when dual wielding #6623

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Conversation

LocalIdentity
Copy link
Contributor

The block the code was in ran twice as it would run once for each weapon. This divides the rate in 2 when dual wielding before adding it to the multiplier
Also fixes the breakdowns as they were very clustered before and included unnecessary values
Added the noTotal part to multiChain breakdowns so it doesn't show the total value when you don't want to appear
Fixes #6555

Before:
image
image

After:
image
image

The block the code was in ran twice as it would run once for each weapon. This divides the rate in 2 when dual wielding before adding it to the multiplier
Also fixes the breakdowns as they were very clustered before and included unnecessary values
Added the noTotal part to multiChain breakdowns so it doesn't show the total value when you don't want to appear
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Sep 8, 2023
@LocalIdentity LocalIdentity merged commit 4fd6a6b into dev Sep 9, 2023
@LocalIdentity LocalIdentity deleted the fix_trauma-dualwield branch September 9, 2023 00:50
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
…6623)

The block the code was in ran twice as it would run once for each weapon. This divides the rate in 2 when dual wielding before adding it to the multiplier
Also fixes the breakdowns as they were very clustered before and included unnecessary values
Added the noTotal part to multiChain breakdowns so it doesn't show the total value when you don't want to appear

Co-authored-by: LocalIdentity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divergent Trauma calculates much higher than accurate values of sustainable trauma while dual wielding
1 participant