Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Tattoos #6611

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Sep 7, 2023

GGG added several new tattoos. This PR adds export and implementation support for them.

This fixes #6606

To do:

  • Parse journey tattoos
  • Count tribal tattoos for ancestral tattoo parsing
  • Add warnings for tattoo limits (and remove allocated node restriction for Makanga tattoos)
  • Implement keystone tattoo

@Wires77 Wires77 added the wip Unfinished and commited for discussion label Sep 7, 2023
@LocalIdentity LocalIdentity marked this pull request as ready for review September 7, 2023 15:53
@LocalIdentity LocalIdentity added enhancement New feature, calculation, or mod and removed wip Unfinished and commited for discussion labels Sep 8, 2023
@LocalIdentity LocalIdentity merged commit e71a690 into PathOfBuildingCommunity:dev Sep 8, 2023
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
* Fix Tattoo export

* Update tree, allow editing keystones

* Tree update

* Re-indexed tattoo export to allow use of the export data when importing and loading

* Add support for Journey Tattoos

* Update Tree

---------

Co-authored-by: LocalIdentity <[email protected]>
@Wires77 Wires77 deleted the new_tattoos branch July 29, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoB not correctly treating keystones replaced by tattoos
2 participants