Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate icdr suggestions #6570

Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Aug 31, 2023

Description of the problem being solved:

Fixes extra icdr needed breakdown line being inaccurate.
Fixes ignoresTickRate flag applying to both triggered and trigger.

@Paliak Paliak changed the title More accure icdr suggestions More accurate icdr suggestions Sep 1, 2023
@Paliak Paliak force-pushed the moreAccureCDRSuggestions branch 2 times, most recently from bbc6131 to 9d303a8 Compare September 10, 2023 16:14
@Paliak Paliak marked this pull request as ready for review September 10, 2023 16:40
@Paliak Paliak force-pushed the moreAccureCDRSuggestions branch from 9d303a8 to 7fd06ef Compare September 10, 2023 22:01
@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Sep 10, 2023
@LocalIdentity LocalIdentity merged commit de4771f into PathOfBuildingCommunity:dev Sep 10, 2023
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
@Paliak Paliak deleted the moreAccureCDRSuggestions branch January 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants