Optimize loading items, improve startup time #6562
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve PoB startup time by about 970 ms.
main:Init() average time
Before: 2709 ms
After: 1738 ms
Changes:
Steps taken to verify a working solution:
Added TestItemParse_spec.lua with a bunch of item parsing tests. Also tried loading several builds to make sure items were the same and checked items from the uniques/rares item DB.