Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for item enchantment comparison on hover #6532

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Aug 27, 2023

Fixes #5778

Description of the problem being solved:

Moving the tooltip from the button to the enchant on hover for faster comparison. Also adding a remove button because why doesn't this exist?

Link to a build that showcases this PR:

eNrFW21z2kgS_hx-hYqqvbqrKwMSCANn7xbGr3V24gMnufuUGqQBtBk0RBrZZrfy3697RgKBGVlCqrsk5QDTT79NT093C5_99rpkxjMNQo_753Wz0aob1He46_nz8_rnp-uTXv23X2tnj0QsPs0uIo_hyq-1D2fytcHoM2WAqxuCBHMqviSc2t-A04r4YkG5_0B-58ENd8_rH7lP68aU-K4nkncOI2H4kSzpeX3iALhukNChvjvafh4TLkhAHEGDe5Q6jAR_4C6siiCC1SXx_Al3vlNxE_BoJZV69uiLorl7ePw0fkqp5PlplcCiD2ePjKxpMBFEGCH8OK8PwTFkTi_JEn4CN8IiYGW22_1Gx-z3Tdvq9Lr1Zib4IgpCcRyHyYpSdwtqdOy2raN9DOjVbEYd4T3TUeCJ0YL4zlaiFleU9iFiwlsxjwYpxbSI2zfMzVZLR_zEBWGXj5Mtbb_TbfQ6XfxntvvZOC42OK2Er55YXDBw6hFS7ua-J2gaaLV7ja7Za3c6NmKzhB4Amz270enaZh9k6kMAwY_cC7lfwjFHKD2KGIODnkZqvTqmIQ2eifB2ldTSj_hy6vm7m5DTHcOAkk8zFehj4npRmOKgAz0Qn4x4uI2PbhblIw0g-YgdQOsdwIQ6HPJVGtJrnGZrFMs5jNYKvPdmND9lIVtiQFFtjrPjapKXrjDj4xQaQ37ORznhEctJKbZJ0so4Pj_ShGZbeygv6Ws-fmlC0-poU5ov8vFLE3Yz1HvmQt7f7zlGJqar28cNZd8yG22zd9rvnXbhTtRecot16DmEPZBXbxkt4XZ5It_pVqBpdvShOl8IH1KaDqt3-7UX0OKoEWfuEagF4WFxGB7E7Q61MgoKZ4C0d76T73R_9gOZ3VN1SDcTMIYzh4XPlNGciK2I-OTmqRWUqDn1Y3nrfObcU-osbqBQHBNB86X3bVmU7VakzeVWJDzgVjsnoICTEKhxUqOfBSropiufBvP1ZOFR5hajThQbkVWOdIpuTqNzuXtXXKGISUMLuuQrCdx8l05RnZ5JmM6xbbuT7S9Fny8yKdTGAHDpXtF-aurbDv47Nh2sIG4YLHm0vfRs0860QpHnMiK5I1TLNaZu5OxcSn0t8oJB97hnQVYwMlYIMRSCON8vuTunhYQUR0yi1QrSBe57XhzecVDHe6my5qSbg_oTRG2uw4vXYX4BW-rcAjYXfH4pe5D8tuAlXcCYLXluEZte_gHywhLyvZwFPPDUOEC7OdC65erDJOFud6g_VfwFNF_gjCcsRg3FzDZZaVUJqP_HOjf_HfJcAq58NwrwKOSWsY84JObJW0LKDMNLIojhxuXvFxJ4xBeWHECFlATO4h62_powNoUEcF5PfyrfyaHVtccEDS7hMxSKiu1zNJNNP2vK4Ru-uluueCAM-or_PZJArM_rM8JCqgjlJ8AnFJ4vG3RIQ4zVjcmCvwzdZ5T0xDkLE5BBVivquzs8ngJKDSKDEXMxKiGNxzfpSd2dK5VekhDsWKsADtE-n4MCkON7vXa7bghgl5oSWlY8AFRw5Pzh7PP4Xr74sBBiFQ6azZeXl8aKiAWf0Ve4axoOXzZXAAKdTsLvHmMnyLY5hD8X86H8Ixk1E05najIYNtU7PIeBB2qpfWyiLdKxaCy--MgFDXENP0zenE1QVAgbFogbugwv1nB2rrE62BtqxN5C6gkVKhDSmGRk6dIZiRh-_q-IMA83r5X-9F5NV30eLDdND7CCzcMUrzg-rVfo3eH9vVoZMhEzQ3HJTqodixUyPDfZxfhDOTwdbrUeEeaEUm_Pd1jkQsMQp5VNpDAyRd1wXIzFvpsew6Y4bQR9OAN9YuIbxqeEWQkkHiJbrfrOupmsyx3G-JgsPSy-fij78JNL5auYBsNdaj2nS1x9oIK4cDabdwJ80USHNHd5SIfvWbBhtfWCwyNfcfbJMj4GilEcUE1pbBxMsZtlQKmQwZeSm6S481eRkJzO60svdL5No9kMx9QgWwRy8n51fX01err7chVnmjRE6vfNj5ZTHMKq_7f3wYTKescIo2moXp7Xv3j0RSpyCQ7xWIgGMUZWId0cdRkTseYMcBncJBU0p8lQ-zCvLYGe09UrDSAzzaFadgKPavXarL-jlBKIlTRmZh03HBXrGakybQRZTFX6Gk_J0byeC47KtebgYgYWcjphWsnx6jueEJgVIEy9mefgpZa95ZhDFFWGXxwH7kNnnbHfcbGp5yFn7zoGalEPVmNwHTpezfCqHMFrvapW9fBL6hCt7WpRD940j9wHN-m4bKgyOH3kvgxyODRDj2FhqN3ZK0Y3JHqGn8SCBvFlreP0ADkqIck8OIE3jYT-GKcoMnwlR1kaD-GaHqrGNRobcC0jE-2MMDQOTdPoWanWX5vIsqCqSdD6L245MrYg7qo17lerGU5IZgsa--PljEMi8-_wmXuuajs1x2WPLCthQNlWno1socuz2W-uy3O8hsr3u3a_41U9_LPwsIg5wEVVMrmY4KEqxwHPVjkO4_1CYosdZ5cQMn9BFUjB0ZkJbEOTsb8i8i_hkhMZe5uTlVTr8EHYmlaIl0rlBy0tzFEFaPxwISuGFck7jOAuus2odvJx2gw8bilh-Mybs3IM3zxEKWUnFyHx3Uuc1ZY0FEe90QqYJZp9OlSubrd0n-tZM2kkZGeOpX08T5iIAPuxPzhf_kf2NfgqbiHbcdsIRd6lB64OZIgkcpDw38ks5Ew2S3EPi6-TFjYKqXqi-pWSFfflx6nuEknTneWYQJm7Hhjj4fiq9hG0RILaREAzi613YFxw8GotvlUGRtuykzcXJEyeK0O3PzBajX7ftmqjgMwEdQcGal17DOjMex0Y-P2djDcT6K1yvIl75oFhtWrxrGBg3JzIvzXpxDH9MTB6rRoU4MxzPFxv1_50lE4_h64bGh3bENzo9gwckBpq5wxvZqx59BdwWfiPZ2r8E-pt6hoQBmAdW9f-FGQeDojsOn7-GRB_Tgethv3TRFZ_tU-6fzOANyBUY2JshpYJ_xW40mq1jKRAN6BvgeVdxpb9i4GTqjdU2LxC6zlGuYaUjk-H7Hq8k3F7q6Ww3qVIZmWyB98NFCsrUIYr-mqMGCVwPDQ7H3vL_HnPHcLufCegEDju7hOAOI6GvpuYrizvadhIZ--yeHrht3Bg-4cDS6OF2i7ZJ_aOjLu92DvdiT2z9ner9QsGSZzpjJhV7bT_C45tlBpGYkocLjUVqKcI7HXerFqnaWwcctIIFNdC1P8rgjIoOu9S2PoobGdF4ZWggQ_uuYiCOWyXqKkiemDYph2_3k9W5v8-T41P5N9UrHT76VhpvTUdx4D6hL47IWRcGNAdLx-nn8f3cqIr51A3jD9jJYJLanrbzAYoMYa5hVjvQeQdYQyn6zCEXVAGG3YBmReUiX28VQAvS1ejfYSVxuSFrPZFd45hVML8mIdVAY_DBnUrMKhbgUFH8ThkkFkkuA5FZ7sCj1hVWVMk3m4ptBiilD8OHLZuaQ2swhy2gPZxIttV-d-uIBjMCo6HWYEenYKRUFWKscqeyE4FDix-Z1SWYttl7bdKHuFiCrhrQxVGZWJQ1RZlOBw-2HZpDt2qttWsKscUD83yfuyU3ku7mqAqYvxwGTEqKsiE7QoSSrvkoeyUxJvV-P_om7Jw0HYKI46pokp61S6bqyvalk5VyaWyuvroFqoAboxjMat0arKq2YPKbooqGr7OcTYVdX75O76iYsMurUj5K65bNBls6c2jksdbgWrqk3wZSU725XeRuD_z5m--WYSzIA8fU-A3VJIJdd2Ycs4o8eOnBU09TM22jwBeUHqsTPymjnwwe6TY2_ekPjLi0AVn-MhC4alPl-v4l3OTr1-dpn8N4xB9_H10DoribDKNzAYmBzGht6xs-vRv9CYY-31I8m2uBNJ-R63NlwUSQPc0G7A7U0_ZnzzWimPyrLn_y-b_BSSg8gc=

Before screenshot:

image

After screenshot:

Boots
enchantTooltip

Helm

enchantTooltipHelm

@Peechey Peechey added the enhancement New feature, calculation, or mod label Aug 27, 2023
@LocalIdentity LocalIdentity merged commit a0c6f56 into PathOfBuildingCommunity:dev Sep 6, 2023
@Peechey Peechey deleted the feature/enchant_tooltip_hover branch January 4, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enchants hover change tooltips
2 participants