Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation popup for tree version convert #6371

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Aug 16, 2023

Description of the problem being solved:

Improvements to version convert: allow users the choice to replace or backup current spec before conversion. Works/looks better with pr 6365 but I want to keep them separate in case we don't add this.

Steps taken to verify a working solution:

  • Convert should replace the current spec and active spec should be the converted spec
  • Copy + Convert should have both with active spec => converted spec
  • Cancel do be canceling
  • Outside of the popup, Convert to latest should still work and show the success popup

After screenshot:

convertPopup

@Peechey Peechey added enhancement New feature, calculation, or mod technical Hidden from release notes labels Aug 16, 2023
@Peechey Peechey force-pushed the feature/version_convert_popup branch from 77daf2b to 71771d4 Compare August 23, 2023 21:16
@Peechey Peechey removed the technical Hidden from release notes label Aug 23, 2023
@Peechey Peechey changed the title Confirmation popup for Version Convert Add confirmation popup for tree version convert Aug 23, 2023
@Peechey Peechey force-pushed the feature/version_convert_popup branch from 7d8e5f2 to 576170d Compare September 6, 2023 23:20
@LocalIdentity LocalIdentity merged commit 828ae2e into PathOfBuildingCommunity:dev Sep 7, 2023
@Peechey Peechey deleted the feature/version_convert_popup branch January 4, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants