Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lancing Steel hit rate calculations #6310

Merged

Conversation

Lilylicious
Copy link
Contributor

@Lilylicious Lilylicious commented Aug 10, 2023

Fixes #1736

Description of the problem being solved:

Lancing Steel was using a DPS multi for its 60% less damage with subsequent hits. This meant that it was treating the skill as if it was hitting 60% less often, rather than doing 60% less damage.

I've split the modifier into two. The DPS multiplier now scales with projectile count, while a less damage modifier is added which is 60% multiplied by the percentage of projectiles affected by the modifier (all except first)

Link to a build that showcases this PR:

https://pobb.in/mMOVEN0vLM9y
Difference is most notable in the max poison stacks, which should not be affected by less damage dealt, and in bleed calculations where it has a major impact.

@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Aug 11, 2023
@LocalIdentity LocalIdentity changed the title Lancing Steel Accuracy Improvements Fix Lancing Steel hit rate calculations Aug 13, 2023
@LocalIdentity LocalIdentity merged commit a0bd444 into PathOfBuildingCommunity:dev Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lancing steel hit rate is calculated incorrectly (as 60% less hit rate)
3 participants