Stun Duration Improvements #6228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is this in regards to stun duration as well #5646, but I think there might be issues with certain mods that factor duration that wouldn't consider action speed if you just apply it directly to the duration. Just commenting in case it is something you want to work on as well while at it. |
This is why I didnt include it, effects like boneshatter do infact not care about it, however I could add it as a tooltip line I guess? |
|
Yeah that might be a good compromise. |
LocalIdentity
approved these changes
Sep 9, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* Stun Duration Improvements * add action speed to breakdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to enemy stun duration, adds support for "more stun duration" as well as double stun chance, and stun on crit, and of the chance mods use thier average value
it also shows the minimum and maximum duration if they are not the same (due to a chance mod)
