Fix accuracy of skill Mana/Life cost calculations #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hi, I wanted to ask if there are any estimates to when this will be merged? |
LocalIdentity
changed the title
LocalIdentity
changed the title
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
…unity#6220) * Rough code to male it work * Recommit changes * Fix breakdowns * Correct values for Divine Blessing * Fix breakdown when using Lifetap or Blood Magic * Fix display of skills with innate Life Cost --------- Co-authored-by: LocalIdentity <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial rough implementation that is correct for all skills I tested
Need to fix breakdowns and clean up code still
Fixes #5863, #5585