Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link skill improvements #6139

Merged
merged 8 commits into from
Sep 9, 2023
Merged

Link skill improvements #6139

merged 8 commits into from
Sep 9, 2023

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Apr 27, 2023 •
edited
Loading

Built on #5959 (merge that one first)

adds support for more link mods, has a few remaining issues

  1. currently vampiric link does not share its leech amount, just make leech, it causes issues trying to get exact leeches with the pass system
  2. missing flasks from belt
  3. destructive link has issues, basic mainhand crit chance is not calculated (eg default attack) so unable to grab it

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Apr 27, 2023
@Regisle Regisle mentioned this pull request Apr 27, 2023
Merged
9 tasks
@Regisle Regisle force-pushed the LinkSkillImprovements branch 2 times, most recently from 0101afb to 29b7205 Compare April 29, 2023 05:55
@Regisle Regisle force-pushed the LinkSkillImprovements branch from f2e1c3c to 33eae1e Compare September 9, 2023 03:19
@LocalIdentity LocalIdentity merged commit 720cb9a into PathOfBuildingCommunity:dev Sep 9, 2023
@Regisle Regisle deleted the LinkSkillImprovements branch September 9, 2023 04:49
This was referenced Sep 9, 2023
Closed
Open
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
@Regisle @shafouz
Link skill improvements (PathOfBuildingCommunity#6139)
83d27a9 
* implement more link skill mods

* fix export issue

* change flag name to parent, and add better support for vampiric link

* implement soul link

* add support for "Non-Unique Utility Flasks you Use apply to Linked"

* fix spelling

* fix soul link max hit display

* Fix StatMap for Flame Link

---------

Co-authored-by: LocalIdentity <[email protected]>
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Regisle @LocalIdentity @QuickStick123