Add support for Momentum support #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another issue, the average is rounded down not up, eg a level 35 momentum has an average of 3.5 stacks, which rounds down to 3 |
LocalIdentity
approved these changes
Sep 13, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
* Initial support for Momentum support * fix movespeed buff * check for momentum support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds config options for amount of momentum (if not average)
If not set it correctly gives you the correct average amount of momentum, taking into account the extra from +1
(though both the average and the +1 are incorrect if channeling skill)
also grants movement speed per removed momentum charge, (though this is missing a cap)