Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where Sceptres and One Handed Maces were considered the same weapon type #5942

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Fix issue where Sceptres and One Handed Maces were considered the same weapon type #5942

merged 1 commit into from
Apr 6, 2023

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Apr 6, 2023 •
edited
Loading

Fixes #5940

Description of the problem being solved:

Sceptres are mislabeled as "One Handed Mace" in our dataTypes, this PR updates the label to "Sceptre". This affected mace/sceptre behavior for mods using different weapon types.

Steps taken to verify a working solution:

  • Equip 1h mace, sceptre
  • Allocate the dual wielding mastery [50071]
  • check increased damage
    --
  • check label on sceptre item

Link to a build that showcases this PR:

eNqtW1tz4rgSfp78ChdV540QfCepsFsQyKUmJCxkZs45L1PCFqAdYTG2nITZmv--LV_AIcixsSdTCVj9tbpb3a1uIS7_fF1R5Rn7AWFet6G22g0Few5zibfoNr48XZ92Gn_-cXI5Rnz5OO-HhIqRP04-XUavFYqfMQWc3VA48heYf01Z6d-B1Rp5fImZN0J_M_-Gud3GA_NwQ5khzyU8fedQFAQPaIW7jakD4IaCAgd77tXueUK4RD5yOPbvxbS9kLMRc2GU-yGMrhDxpsz5gfmNz8I1SNVQngl-iWnuRuPHyVNGJOJlRQKVPl2OKdpgf8oRVwL41W30wDJogQdoBb-BG6IhsNJbuqapttFpa5ahmY2zXHA_9AP-joPZPtds07L183OjI-MwXWPsbkFaq63KKMc-Hs7n2OHkGV_5hF8tkefs5jNbUikPUOutTi75KKScrCnB_haiyie4fcffbstonxhHdDCebkmtlmXbpq3qpq6rqpmPY3yLk87wjfBln4JZj5hFYO8WHuH4SPCYkYB5FfTLQqUqXoWUQpAWop3gAPvPiJO3Ysl5s9WMeEdZb4Q8dMWCAmskKMfYhxTASwGm2GGQNcrOURJ5T-a4OGUpPRJAWWmO02M4LUpXmvFxAk0gQxajnLKQFqTkuxwlz9QT_DNLqBoywgF-3bGTTnrn7SRT2zmx9zNL2ZFP-sx4tC1-pG2UJoa3452M51ZLNc4NW-9YHV2-eyw3AXEQHaFXsgpXkLGf0A_sZSxnyP1vseQepBsZVjXPZdhr4uMjYFeMusfAlogFR-BEhBWxBGzWzoUgvvOcYnH7xfOj9Jvd4_MsPccTCCdRVcwoLgrZTZJEZRHXjOdaYC-ZcJOpJNQ80D3GzvIGCrEJ4rhYFt7J02nn2lYQF7KtIDxg2xz-bxElDCWAhw1ltIw8UElDDT3sLzbTJcHULUedCnaF1gXSpbBzFl3I3m-nO2SMQtCSJvmGfLfYplJWpmcUZNOtauWbKyYv5pkYSk8AuHivJG7LC3v2tyjraTlYz1-x0C-44DFxIQXSnSLuZybYDZ1iW1OfQme2J72WZ1hKD0HkzRbnyPkxYO6isI2iScojpuF6DZlCrHlRnNjooNImmYrl1CpA_QgOWyhuxZZYfIIddeEJttt88Vn2IMV1Eft0CWV25IWn2LbKI0gJK0j1UaM9Ypm9Qro40FwV6pQiwoId25i9gORLcYASlKOGembXtktF8bH3a1OY_xvyQhMMPTf0RSgUnmMfcWiaJ7KCdBkEA8SR4iZF8FfkE-RxLTrdCTDyneU9LP01onQGCaDbyD4V7_aAarq2l2fRCZZ4dbdaM59HD68QdYJo9jtvHXLFi06fViRwvs_C-VwcJcEE3I-Ox4bX18Orp7uvw0TgLCT4QSj97oWrmTglif_u3GqKo7SpBOEsiF92G18JfpkK1ABzRCgY0WGUonWA3W5jjmgAMxN4GdFMwTIOz-EWUUGZmx48Hea1I5BzGr5in4O-sN86PsFSubbjHwgVTyj2YrHAMm7iMEfOKM72Vyjgca0gsVR0fCbnIs6ypOqIwRws-Ayi0pmT0Q8swTdrHMAGTObEEbGRv-RPQB1T5djFcSCsnE3Oeid7lpxHdDomYxAPysHxCZcMnYzmWDU6XZNaNR6VwwfYQVLd40E5eFt-Mg_MJOOypcrh9MC8yMkhaHqEiv1FurJDirckcoaPfIn9eNOSchpBjkpJcgPHJ7OQy8M4Q5Fjq6gnllhIjMmhccsn0UGM5WSiN02QxKBZGjmruHmQJrI8aFxrSO2XVC45S5CU5hLzx6M5Rki7E4n-yXBOkET5t_fMiBtXr5Jw2SPLSxhQp1dnE1Xi1dns1-jVOV5TFPyQrncyKod_geaN8M0BLvHHVoWYiKCqxkHEVjUOk_1CYoed5JcQUf4a4DkGQ-cmsC1Nzvry0BvAJsdz1rYgq0isw4GwU60UrziVH9S0NMfYQZNjyjwfjkk-YAR70W1OtVOM07ZvusWIio-zGK3G8N1xbCU9GQ-Q5w7EaU9FRcVhUbgGZqlkj4fK1d2S7nO9PEsbicuodguUADqMG7wK-hvoCK_F7rT3YRqKDJsU9zxub7KYdDoXz1FIxfO_QiQSi-iyMk_v40_kPeavtgf6wGrJXkRSjDmKUjKAveb-Ph7pUZ4wE9Ol9oqtkwgUqZl2TrFO4uWTj3EqOlSygiSGwZvsp_h3biTmCip27G-SOqXb-Mdst221aVjGuf4b2iRor-CprXc6TbPT0fWmqpu23tR1wz5vapZttJt6p210mpZ-bltN0zZMu5ny0GHU0Gyr3VTbxnm7aRqqYTQNWzPVpmnqwMdo6xagzPO21bTa-nmnCWwMvaFwUCNzc0FTk0sJsdhCo0-XXyb30YtPS87XwcXZ2cvLS2uN-JLN8SuhuOWw1dkaQGCL06j9OxVsz3rwr7_o9YbLX87DX9-uXrVlm34emNZj__XFxGr_s3P3eew_Le7JkzbUXJ-viXVqzcYvvT7_vz6gL91uJMBZKsFlfMshiP33TNg6WhaxGOLFA4PqTYyJh-mbaKlEj5n0x1Pui_b4F2Or_3Ubhm20NLC4anTE_9gtIMr5CK238SNoE_eyEpeCfmRAYDX9KJulPioI_9ttaLbZslXb6piq-B87zx0HF0tcRrxOnT0McPxh4TeM1syLHmf8UJAmPhjZYALtPN9cKA-Pk1Hv_mTgkzl_YcxVpg5eg91PEoe-ULT2SWKvC6V_Cj8n0J1R4hDxQD35h6NFcAHttMjciH53o1BuJn-2z3-r7f8oxHN8jCD2lWH6XIlDP1qWEXMnyFtgxRe_wXNaZiMTN7AYQou36mgfqHNFw9lhXSan8PNWFyGjL85khYQeXm0UsVsqT0uohZaMukdLqR-UchJ6xFFuEXeWmOcJGTnNBP-8UGz1kPXXyanynvHTx79VLWv7G8pmYPj0KLrCCoi8Jve7rLtdTimDHAiY8QzCUEROfM4DwjyLnV4MxdniLB8QT6OoO4j6EaTPYGdTerNNEIC6sW0Vs8ScfUz5Pl4rgY9KQ0U_Qktl-oLW-1MbxzCqoH7CQ6uBx2GFrBoUsmpQ6CgehxRSyzjXIe_Ua7CIVpc2ZfztFkMJzyvZ40CwWZUl0EpzqDylXpf9zRqcQa0hPNQa5DBKekJdKUarGpFGDQYsv2fUlmL1qvprFUO4nADuRolP8qr4YFxbVOFwOLDNyhysupZVrSvHlHfN6nY0Kq-lWY9TlVG-twop5jVkQr2GhKJXDEqjIl6tx_5H75SlndYojTimitpBtGOsalbN1TUti1FXcqmtrj66hSqBmxBvUWrVD6cmrZ41qG2nqKPhM47Tqazxq-_xNRUbZmVBqm9xVtlkUDV5vJ8wPvWZYh6dkkYHkNFdH-bNyeLdzZ3976zt7vtEXxR7f9XHxwHY3sHiVsDbC0K9r8NJ7-bQ9aD9b6F9OAkWx3l3QZ8FQTHaKfmFx-JGM9_Rj7BLwtUBRPx9vIOMxxQ5WBweYv8N-_iraenFJjt7RfoQfXJhlFEaHdBlkfnANAS3V6gMIx-Q_UJbCjI_hqQXpVKI_oFc28_hU4ChdfIRb-_O7oAJ7vIsdcjLs_2vW_4LQLdCyA==

Before screenshot:

image
image
image

After screenshot:

image
image
image

@Peechey Peechey added the bug: behaviour Behavioral differences label Apr 6, 2023
@Wires77 Wires77 changed the title Fix label for Sceptres Fix issue where Sceptres and One Handed Maces were considered the same weapon type Apr 6, 2023
@Wires77 Wires77 merged commit dccce1f into PathOfBuildingCommunity:dev Apr 6, 2023
@Peechey Peechey deleted the fix/sceptre_labeling branch April 18, 2023 16:27
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Peechey @Dullson
fix label for sceptres (PathOfBuildingCommunity#5942)
19862cf
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
bug: behaviour Behavioral differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Sceptres" and "one-handed mace" are considered the same weapon type in POB, but different in-game
2 participants
@Peechey @Wires77