Hide the power report on loading a build and unchecking "Show node power" #5932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nostrademous
approved these changes
Apr 5, 2023
|
LGTM |
Wires77
approved these changes
Apr 6, 2023
Wires77
changed the title
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…wer" (PathOfBuildingCommunity#5932) * Close power report when disabling node power * Don't save or load show node power
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5903
Description of the problem being solved:
Show node power causes severe lag. For almost all usecases, it should not enable on load. In addition, if show node power is disabled while power report is showing, it would hide the hide power report button, but keep the report open.
This PR removes show node power (showHeatMap) from saves and loads. In addition, it hides the power report when the show node power checkbox is toggled to false.