Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Formless Inferno not increasing minion life properly #5874

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Apr 3, 2023

Description of the problem being solved:

Mod was being parsed, but resistances were being calculated after minion life already was calculated

Link to a build that showcases this PR:

eNqtHGtz2rj28-ZXeJjpzO7sTcA2JjST7A5JSMpM0rKQtPd-2hG2AG1li9pyUrrT_36PJBsMWH7EdGe6xjpv6TwRvfzzu0-NFxxGhAVXLfOs0zJw4DKPBIur1vPT3Wm_9ecfJ5djxJef5tcxoWLlj5NfLuWzQfELpoDXMjgKF5h_TinZfwOlFQr4ErPgEf3DwnvmXbU-sgC3jBkKPMLTTy5FUfQR-fiqNXUBuWWgyMWBd7N9nwAuUYhcjsMHwXUQc_bIPFjlYQyrPiLBlLlfMb8PWbySQr0Q_KpgRo_jT5OnjEgkyIoEGv1yOaZojcMpR9yI4K-r1sDl5AUDKEj1QHzCgSKiMZA7b7U1KGBLtMAfMrCdEtjrOIz4LfLhsRxnusLY24BZOrBxiIfzOZby34SE3yxR4FYgXxf2MaacrCjB4QbePHN0GB8OiJsdLfknxhG9HU_LBVGQrILFvxC-vKZgwUp0BfRoERCOK4OPGYlYUEvqSsA3MaXgeJVgJzjC4QvipKIgN8yfkaCiTR5RgG5YtLW12SsCHeMQXJnvYHRKEKbYZeD9WRTbqsAkH1XL7YHMcXXIWookCHWleZsew2lVuNqE3ybQBAJZNcgpi2lFSL4NMFbByf-WBTS7fR3kLf5egd4o4NW4ZgFNx9FzfWFcZrhKwWH4Ybylap-_P7PNjt3t9q1zrc-Nl-uIuIg-ou_Ej30IuE_oKw4yWlj6E7hY8gCCjA63r7XmHQmxDsvpFQQe6tVnBhmERfXRhINlTkZRgnUvBPAocKu57XMQyoibycsF9AXGBLxJ5P4ZxVVRtkwSp6ySQhWvBQ4ShutqCj1g7C7voZyaII6rhe3tdhcbVsBWMqwAzDGsUxGhhpEEosZIZ--LkGqaaRjgcLGeLgmmXj3oVLAbtKpUILoXWexK5t5lV-vEZFFrmuQLCr1q-aSuTC8oysZZfZGizKXAqx1MDPUjIHi4ap08Dtk_ohKn9dAGoc_ibTLrOlahDgq8kgppklA9xwR7sbuTld5rMa8pNFhVFQCxKK2FMeAcuV9vmbfAtZjUx5jGqxXECrHrVfFEkoPSmmTKlXOnHPgTnNis4_Ztpygf7nE4Lc6e-Sw6pSm-Opc9lMqsZJauocwWvDKLTYP7CFHBh2gve2No97dur90eaKcqtTsSsGKPNmavIPlSzEGietBQzWxbHa0oIQ5-rCvT3wGvxGAYeHEofKEyj32MSmzKhypq7XBQsjcj6ZvnZ1av1zFtu9871yLvTkzMM8tpDnkwmzA7lnnm9C3H7J3bdglezqTiADJ3UlGRS_7cogby4RSjpn55_nIAXDDTOIAtmWkc0s6ZaVTUYa9RcDYdUy5kcWGSi1JcJB2gFNaNhdA1ZateyD0RH6qgKLpFHBle0tR-RiFBAbfk4DXCKHSXDxDO7xClM8jqV63sW_FpD9FM4_VlW86WxdPIX7GQy5c3iLqR5D4KVjE3AjkYjpbsVSnSMmaMUYyCZB7cPoT9Sij9O4j9mZhWqv9vc0QW0ieR-_csns_F7BjE5qEchw_v7oY3T6PPwwRlimXdZETxLFKPV63PBL9OBaNbzBGhEERdRilaRdi7as0RjYAegUcJMwUruryAmoSCJjeNfPm0tgB6SsPvOOSgBZTcbkiwVq7NeolQiqE4WeIw6KiJUKcnpMq9GxRxdco0lpJRWU9FjKG16ojFAlw4X4hqOSerJZbg6xWOoAInc-IKbyre8ieAVlAFdnFdSKvuumC_k6JVT0PmDh0BtahHVvFfh52sFlhV5h6tVdWqHv0Wu0iru1rUI28CFwvkdzD5VDZQBZQ-QqoRhxycZkCoqC-1OzukeAOiJ_iJL3GoilYtpUeIPClIoeOEZBZzvRtnIApsJTOdxkJiTY-qZj4aHcRaQSTayWcag2Zh9KTU_EAbyIpQVa-htV_SuRRsQdKda8yvVguMkA4oNPonywVOIuPv4IURT7WvGnfZAysKGNCoNycjW_HmZPab9OYU7yiKvmr3O1nVoz9zQglf51BR3z5XIiKcqhkF4VvNKEz2C4kt7qS4hJDx6xbPMRi6MIBtYAr2l8fBLSQ5XrC3FUlJsfIdYataLVoqlOdqWpuiOqDJlxRFZ1iBlBCCXPShoNqpRmkzN_mAERXNHqPNCB58GdNIT8YjFHi3ondpqKhofeIVEEsl-5RXrm63dJ_qZTttOi5l7RYZEXQj99iPrtfQWN6J7LTXaiJp2KS456oVyuKk7Dw8RzEV7_-KkQgsornKvH1Q92oCFvqbL_OAFHQ7IigqiqKUjCDXPDyolQHlCTHBLrWXsk4ikFTTlO-Sl_LazGArtdRYyk0Cl8YeHgXJsAykIXBQKJoJycQ1IfH9lZe9fpOhs2HzyyVIkwDfUzZD1EpRZEOWtKG7vDMrycsJIrBb06_QMXERMpKLR1antUPb3KE9ElV37PuCvkKMDrlKht-U4UaywpSb0DIW2BefH6GR86DRbY84mLUtbNuWiPB0QPxbZjf3DARnMVAnQjSZYmafCmfkS3egdFvtm-Jevodyu5ruooAu28fKeyH1EZrzEL_Z5rlEqhpcIhsp9oFBk0fwFOn-yuvF41OIcerckpCZOBZ8yF5XE8J3hBkjjsN1UskLOwfME87q9Pu23TKAOc5clbPM5BacQldSPU8elOGXnK-ii3b79fX1bIX4ks3xd0Lxmcv89gqQQKZTaeJTQbY9gD_Xi4H8o9RLKV2q63FRO1EVZJdqCuXEw0cG_YJYEy_TD1J1MdVIpjdTHgp9fjDm_0_qKkIPZBL-iFbJ4RJrSQCzk6AFHe8tAWuEMl-mOyQA_5uOlS7lXidGFs9pAI1hu-X1ky8YrcDbxOv0WEok40VNkCS7TISbwGu-vjCeP47-eh6ePC2xcQcBVUyujFEAwgTsZMLWiBrXcbhgAeYnqnC_MLqOlTxfoyi9mANGvzA6Jw8YLWJ4ug4xcpcnyfjqwhiH2LDPzN5ZZ_-dZWbf3cQhmIGfqOkP9ozNir0vThLPLwyrc5Js3oUxOZX_nUgTT_C3C6PnnIz8FSUuEeudk38Tg1zYPxUWMLmXxgVxIpVA4NVsrVzXsDuJPYD3A17AqdySMP9j_fw3RMECX3TOnJ-_9junptX57Z2ILGAAiE-GMpQW5fdfu51Tp_ObwRk4hkxlhqiEs2LugPeARScH_tTuvBMvxZdrhurQRMm3y7j_zmBzI_2K01A53ZiHzDdE6WRwkd7BZRUVtZyh8FMpY5AooyAY6jlw0WoFz1rmlg5VVB1lyPZPFfOlonUoCLd-ZN5EmM-QRhT3FpzUD5IIp4WwSiHsUohuKYRTCtErhTgvheiXQqTXOWRa2YQPURfpYsxuwUQZVFCAMZ5BSJVRXY6LId29iD5BLKkI3i5GUEwMswbKNYO62BjM1lEEp1p5teHUIYAp38e3auDLxtKw36ClMX1Fq33W3bcQaqB-QsM6Ao18hXpHUKh3BIXeRCNPocan0z6CRaxjaVPnvH3A1Me8kT1ynK3XWAKrNoUtgvk2lvax7O8c4TCYR3AP8whydGuehGOFGKupR3aPYMD6OeNoIdZuqr_V0IXrCeCtk8q4yRlUtUUTCvmO7TSm0DvWtprHijH1j2ZzO3Yb76VznENVR_mBH1PMjxAJ7SMEFLuhU3Yb4pvHsf-bM2XtQ9utjfGWKqqhVZ2msfpI29I9VnA5Wl395haqBt6EBItaW5gfmqzj7MHRMsUxGr7u23Sqa_zmOf5IxYbTWJDmKa5XNxg0DR6HDNXMJx3sy1GzvFXIgjlZHFwADHEEpnSxuCK0ewdw8Hk4GdwPcy4N4gD761F0zaJoCy5_XH4I68YRZz5QzoD-bnY6nXfGXAz4ws2ALwd5_1f1pdzUz-1LwaQCU_IDj8WvqDLwj9gjsV8kSfJj-lwWY4pcvGTUw-EOI3XZOr2GeZ79gVYevLjJl16DTJHsEpzUdVN4yyrnkf4cJMVxilF2f0uT0acYbXP_J4XvlSAkv9VhlMrRZtZw6XfVyVG-bO__Yw3_B1RVB3Y=

Before screenshot:

image

After screenshot:

image

@Wires77 Wires77 added the bug: calculation Numerical differences label Apr 3, 2023
@Wires77
Copy link
Member Author

Wires77 commented Apr 3, 2023

Note that this change will break any mods where player damage/defense is based on minion life. To my knowledge, that is just Jinxed Juju (unsupported in PoB), and various items an animate guardian can equip (also unsupported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant