Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.21 attack and lightning masteries #5842

Merged
merged 4 commits into from
Apr 2, 2023

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Apr 1, 2023

Description of the problem being solved:

Implements the following attack and lightning masteries:

  • Monsters cannot Block your Attacks
  • 5% increased Attack Speed per Enemy in Close Range
    • This requires setting both # of nearby enemies config and "at close range" config to apply
  • Nearby Enemies are Intimidated while you have Rage
    • Followed the existing example from "nearby enemies are crushed while you have ?a?t? least (%d+) rage"
    • I originally tried to implement this using a more general "while you have rage" entry, but didn't end up getting this to work (I suspect my naive attempt might have been ending up trying to apply while the enemy had rage)
  • 60% increased Critical Strike Chance against enemies with Lightning Exposure
    • In order to handle EE correctly, I created a new Condition applied after the EE applicability calculation and based the new mod on that condition, rather than attempting to use a threshold on the base LightningExposure value

Steps taken to verify a working solution:

(using the showcase PR linked below)

  1. For Monsters cannot Block your Attacks, the provided build has some monster block configured and the mastery selected; verify that checking and unchecking the mastery impacts double strike damage but not the spells' damage accordingly, and verify that with the mastery checked, double strike's damage does not change when modifying monster block chance config
  2. For attack speed per enemy in close range: verify that double strike attack speed is updated when # nearby enemies config is modified and "is close range" config box is ticked, but not otherwise, and that the spells' damage is not modified
  3. For Nearby Enemies are Intimidated while you have Rage, verify that ticking and unticking the mastery affects damage appropriately if-and-only-if rage is configured as non-zero
  4. For crit chance against lightning exposed enemies, verify that with the mastery allocated, crit chance increases either upon setting WoC exposure config to lightning or allocating EE (but only if an appropriate combination of "Enemy was Hit by X Damage?" config boxes are ticked)

Link to a build that showcases this PR:

https://pobb.in/A-izFWEEUewD

Before screenshot:

screenshot demonstrating which attack masteries are supported before this PR
screenshot demonstrating which lightning masteries are supported before this PR

After screenshot:

screenshot demonstrating which attack masteries are supported after this PR
screenshot demonstrating which lightning masteries are supported after this PR

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Apr 2, 2023
@LocalIdentity LocalIdentity merged commit d5cd4f9 into PathOfBuildingCommunity:dev Apr 2, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
* support nearby enemies are intimidated while you have rage

* support per enemy in close range

* support monsters cannot block your attacks

* support against enemies with lightning exposure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants