Fix cluster jewel notable compare tooltip when crafting a cluster #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When creating cluster jewels in pob, the tooltips for notables would often mismatch between tree (correct tooltip) and crafting view (incorrect). Sometimes the differences were small but other times the crafting view would show complete nonsense.
Link to a build that showcases this PR:
https://pobb.in/F8rBJoJDXFpB
Tooltip when hovering on an unallocated cluster node on tree:
Tooltip when hovering on the same node in crafting mode before:
Tooltip when hovering on the same node in crafting mode after: