Add support for jewel limits #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
reviewed
Mar 31, 2023
Wires77
reviewed
Mar 31, 2023
| item.jewelData.limitDisabled = nil | ||
| if item.limit and not env.configInput.ignoreJewelLimits then | ||
| if jewelLimits[item.title] and jewelLimits[item.title] >= item.limit then | ||
| item.jewelData.limitDisabled = true |
There was a problem hiding this comment.
What is this line for? I don't see anywhere the limitDisabled variable is used
There was a problem hiding this comment.
in src/Classes/PassiveSpec.lua to try and disable historic jewels, also answering the earlier question, no they dont have limits ingame, we give them limits in the unique data, but they dont actually have them
Wires77
approved these changes
Apr 1, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Initial Implementation of Jewel Limits * Fix Timeless jewels --------- Co-authored-by: Wires77 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built ontop of #5664 (So that one should be merged first)
Implements limits for jewels as well as an option to ignore the limits
This correctly limits most types of limits, including basic ones (like anima stone), radius jewels (like unnatural instinct), grand spectrums (limit of 3 across all grand spectrums), impossible escape (though this is a little buggy as it doesn't unallocate nodes that are allocated)
This is broken for historic jewels atm though