Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nil comparison if maxPrice is empty #5318

Closed
wants to merge 1 commit into from
Closed

Fixed nil comparison if maxPrice is empty #5318

wants to merge 1 commit into from

Conversation

Urganot
Copy link
Contributor

@Urganot Urganot commented Dec 13, 2022

This error occurs on the dev branch

Description of the problem being solved:

When max price was being left empty, options.maxPrice is nil. This lead to a nil comparison error

Steps taken to verify a working solution:

  • Import a build
  • Go to items and click "Trade for these items"
  • dont put a value into Max Price
  • Click Execute

@QuickStick123
Copy link
Contributor

A fix for this is already in #5314

@QuickStick123 QuickStick123 added the crash Causes PoB to crash and is High Priority label Dec 13, 2022
@Urganot
Copy link
Contributor Author

Urganot commented Dec 13, 2022

Cool :)

@Urganot Urganot closed this Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crash Causes PoB to crash and is High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urganot @QuickStick123