Fix fullDPS having signifcantly larger numbers on second pass #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
changed the title
QuickStick123
changed the title
Wires77
approved these changes
Dec 14, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5258 #4982
Description of the problem being solved:
preDamageFunc and other similar gem functions were getting called twice between comparisons, it uses previous dpsMultiplier in calculations this resulted in the numbers being ^2 on the second calculation always making every node seem more powerful then it should. This fixes it so it always wiped so this assumption / reuse of stacking multipliers is fine.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/TfhBprEH-M3D