Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Master Of Fear #528

Conversation

optionsreaper
Copy link
Contributor

Adds flags for Intimidated and Unnerved
450

MasterOfFear

Adds flags for Intimidated and Unnerved
@ppoelzl ppoelzl requested a review from NickRyder March 14, 2020 01:41
@ppoelzl ppoelzl added the enhancement New feature, calculation, or mod label Mar 21, 2020
Comment on lines +1116 to +1121
if (isAttack and enemyDB:Flag(nil, "Condition:Intimidated")) then
takenInc = takenInc + 10
end
if (isSpell and enemyDB:Flag(nil, "Condition:Unnerved")) then
takenInc = takenInc + 10
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing custom tooling here - could we figure out a system to differentiate increased taken with spell damage and increased taken with attack damage which doesnt explicitely reference Intimidate and Unnerved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an existing way to link a condition flag to a specific damage mod?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from config tab
enemyModList:NewMod("DamageTaken", "INC", 10, "Unnerve", ModFlag.Spell)
though I was under the impression we dont implement these kinds of things as plays can just manually check them in the config tab

@ppoelzl ppoelzl added the wip Unfinished and commited for discussion label May 24, 2020
@Lothrik
Copy link
Contributor

Lothrik commented Jan 20, 2022

Closing as #3803 implements the same notable and is already merged.

@Lothrik Lothrik closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod wip Unfinished and commited for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants