Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing uniques for 3.20 #5184

Merged
merged 9 commits into from
Dec 4, 2022

Conversation

ifnjeff
Copy link
Contributor

@ifnjeff ifnjeff commented Dec 2, 2022

Description of the problem being solved:

Implemented all changes to existing unique item mods and availability from the 3.20 patch notes.

Steps taken to verify a working solution:

  • Manual inspection through item tab

@QuickStick123 QuickStick123 added the bug: accuracy Wording differences label Dec 2, 2022
Variant: Current
Limited to: 2
Limited to: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the limit known to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It changed previously, seems to have been missed. Current Spirit Guards is already limited to 1.

Co-authored-by: QuickStick <[email protected]>
@QuickStick123
Copy link
Contributor

QuickStick123 commented Dec 2, 2022

This looks good.
Only suggestion is to add corrupted outcome to the unique source filter options.

You need to be careful rebasing after #4952 is merged as the life gain and similar is a different wording and some bases are merged together e.g. Essentia Sanguis and replica soul taker source.

@QuickStick123
Copy link
Contributor

Sources of curse on hit will not have effect anymore this includes

  • Uul-Netol's Kiss
  • Dreadarc
  • Asenath's Gentle Touch
  • Chernobog's Pillar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants