Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare templates not getting implicit mod tags #5149

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fix rare templates not getting implicit mod tags #5149

merged 1 commit into from
Dec 4, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Oct 20, 2022

Description of the problem being solved:

When editing an item from the rare template list, implicit mods were not affected by catalysts

Steps taken to verify a working solution:

  • Used the crystal belt rare template
  • Added Tempering Catalyst
  • Noticed the energy shield implicit changed properly after my fix

Link to a build that showcases this PR:

N/A, import from the rare template list instead

Before screenshot:

image
image

After screenshot:

image
image

@Wires77 Wires77 added the bug: calculation Numerical differences label Oct 20, 2022
@LocalIdentity LocalIdentity merged commit 681e5fd into PathOfBuildingCommunity:dev Dec 4, 2022
@Wires77 Wires77 mentioned this pull request Dec 7, 2022
Merged
@Wires77 Wires77 deleted the rare_template_implicits branch February 8, 2023 08:38
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wires77 @LocalIdentity