Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Divergent Fist of War increasing Stun Threshold #5145

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Fix Divergent Fist of War increasing Stun Threshold #5145

merged 1 commit into from
Oct 20, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Oct 19, 2022

Description of the problem being solved:

Divergent Fist of War was increasing stun threshold instead of decreasing it

Steps taken to verify a working solution:

  • Create a build using Divergent Fist of War
  • Note that it increases the stun threshold

Link to a build that showcases this PR:

eNq1W21z4jgS_jz8ChdVe1-uJrwF8nLJbpFAEqrCDAuZmbtPW8IWoB1ZYmw5GXbr_vt1SzY4BDk29s1UJcTqp1-lVqstrn776XPnmQYhk-K63jpp1h0qXOkxsbyuf3m6-3he_-3X2tWEqNXnxU3EOI78WvtwpT87nD5TDri6o0iwpOprwqnzB3BaE6FWVIox-VMG99K7rn-SgtadOREeU8lfLidh-In49Lo-cwFcd0joUuHd7p4bQp8wMZPud6ruAxmttdhnRl_G0gOa0XjyefqUEspEWijo_OFqwsmGBjNFlBPCj-t6H0wnSzogPvwEboRHwKp1cdJsnXcuOr1Wq3lxXm8cBs_WlHpbUPOkd9a2kU4COlwsqKvYM70NmLpdEeHuBDZtuKK044grtuaMBjtjTro2xMMb5hcXNtonqQgfTGY7vu2Ts_Nmp9fsNnu97nk2Tqr39f_G1OqGg0uPkILY0VIwRY8ETyQLpShhXxpqD1HEOayffLTSnzNxlDf6ASWfF2bCTYnHonDL4dQa4DER5FaGu0C1rKo9sgV9RWqlHM7y0U1h-eWjRDUnNIAEofIBUNlCgFjCjLoSklARGUUgKTuOE3YEcjg7BnCEoJna5Z-2Pej0R5qw1bUmqgH9mYPfSKgcVAP6LJXeZt6zQi_t4cNkp2GvZU3wq03IXMLH5CfzIx8y6xP5TkXKuAt7PJcrJSAt2LAXFyedM6tv7lhAj0PeSu4diVwRGdqgnTP7joNzd0vYa2bsrO4l0o6Em29BfBEBDWnwnNqQe5mAKUxn3PznnOZE7ETEiyKVKd8RtaQilrfJZ84jpe7qHuqdKVE0XzLZUnWz3Yq0udyKhAfc2s0JKOAkBFqcdJK5XxV00zcSeDmSnqDBcjNbMcq9HIVRmjzR_5ascyB1ONLwXGF5La_QzEpDC7pu-EzCdNJs9bKtMuT55hmFog8AHs1b6U4C-SfW0rwYrB_4Mgpy7F5ogSHOZUCS-80pYkq9yM23wdxwOM3k1R604rwQoq8Ucb8PpLekhYQUR8yi9RrWPYY8Lw63rSkNWaqc-NjLQf0Zpnp6eTWzdrf8AnbUuQVs9-38UvYg-W3B_baAMTvy3CK2x9MxJBMfErc-3cLROp2Lz6zxgYNNrlONJsx5WprIF1B-hY2FsBg1lCa7csSqSkDFX5t9_vnIcwkYCi8KcDXktmEfcUjME_MhYYbhgCjihJQE7uoRAn1dr6f-uiOcz2Hxw1NEXTV0uwY_jfy1DJR-eEu4G2qeI7GOlCN0r8VnofvHPFossK0CPFWge0HDu7vh7dPo6zBWIw0JvzPO_xCRP8e-g_mN3RlDOaM6HTphNA_Nx-v6V0ZfZogaUEUYB9e4knOyDql3XV8QHoJkBh81zQzsdVUGN00FdWjSxjnMa0dg5zT8SQMF9kKl4AaMWvXajr-jlBGI2zOGzcYN2yN2RiaN35JQma3a4indjLJzwe6Q1RwczMDCnCHcKjkefccTarOmIWysbMFcnPHZIX8CakOV4RfXhcXibjLiHW9Gdh6632RjYAbtYNMzsqHj0Qyv6n6V1atm1A4fUJdYbTeDdvC2-pMC3GTjsqXK4PRJCj3JYdH0GceNwxrZIadbEjvDz2pFA7MbWTmNIUclJJkLJ2DzSNmXcYoiw1f6zGrxEI7ZoeZcZrEBxzIy0atTiMWhaRo7K3PssSayLGhSMlvcZ0YzjEhODRb942E7A1PEWOMXl0RZ6xvqZfv6xkE72KyPtyxUEOXkoOfygC4oZKHMybylyciiKhIDSHgqw6E5WZldqf8smWeK9VLctJGHme08VYiXSRIH_VaYoz7MlHX93hmnEvfHTTNL_k6RvMMIEu9Dxtaej9O2-n-ghOPbEMnLMXzTHCxlp1QhEd4Aux25Db1qJPXtlS4pQieEwvee-uHNBo4fd5g0996y-ETBfkf9R3yr-SSxCCeuosGjecsZCyPaUXFlqvRbyFeck0nq0QWJOD7_PSKcqQ0W_qmnMVfBwNXhSr7gBDN8sPoJIb0-PpqRPlcxCxSSKGLcFauhXdDSz-KH-nVpf6er9obWlgmXRx4difjUFuvAyRz1wRfA2BXdLrY9PlsxH65Am5j4nss54e0EEr8Wbjfrr8Zbybg-MIyw2DM2TyO1wjNN3flh7MQxsJoGAkredt1ZUh8fjeG04MG5pzFS4IgGeqOxc9sbLrpZuW-OKyNhooaHF-z1wD6SIBuVWdbHJKACwmec-LGO8fCYCeyNgQnJ_LFYraknJDBEuXxwh2f-BezqxZ2AUEcuHA1OKapLcgVazaXCNkmFTsL3-MJDD73ywcCskWyTkQd8OsAit8UG6xjwa4sj35eQFiZwgFAk9PPb3Mo55XE7Pxz4vKF-xSG3zRplrLkyTtR5pJEkEp05TcLEj08BpUnG0_hWnHfgj_Q9DVS3ibkiBCs2cW2OyURID3NZ9_y806k7Ctil7oi0LuLrHwZutPoyfTTOXim1Di8bjZeXl5M1USu5oD8Zpyeu9BtrAIFOH7VbPyLbRh_-3Sz7-p8xL-F0ZW6NhI3YVNBdm4nG4YdPEk4AOIYPkz-06diniNsqMxWgPX9J6f9H24qZGbZLNSbrOIPiWJzVO3FOhzPsgIE3Al0UJIFBwn8nfaArHd3YyemsEIXUvHT9RslaCv0Y5Zj-CxA6zyRgBEPcrqc3gCk8VptL58un0e9fhrUBI7Bh_gN4hP8KnTEc1hdE76y1GeyYyfOpnNOaOVE45khx6Vx0a-kzxg0JkzfPEIdLp1n7ahS4dCYBdToneHFm9-w2CsBsVTP9G-o525H2W8nxBgdjzVocrkvn5uP2f007dkp_XDqds9rIX3PmMqRp1nBdOC4Rzpw6BgqymHDUioWO9hNbColtrHjYgTQGB5fa37H_Llv_1TzS4Cn8ivVwVuSZOv9sOUo6WosdsJ0H2D4APCDxHuab2JfZ_AXBsXMy5R6CdyzwA9JveES36CVs-U67-wuWCgGFqHvO8OeaBgxncaYWb9m0mk0LnwcSQnpwtodwcN2PiAW6-xzqdTuW3pSIJXUC_Ikt6K6Z6MnVF50Zt-sB6yDbonldIHEJFRMgJnPIETpN6UamwTit2QtZO_35JgwJT-YMSlYmLzeTBPoen30e7SN4FIDcSCiUq9D7kP1FdL-hXJXB38Ge8N3pFNe8fUjzTgWRO8KL7f8Hj9MKbOlVoEevotiUnt5FgvtAuU9VKRUOTOxeaQ2KLA0oK5-xJ1JSZKeirNAqrclpBbOxVcGqOC04DQrHrJTAQ1O_Cs8Vz8rdsmqX3Ug6hRTwNo5pU5eZM4cDWH7ud0tzKJ58Cge8vKO61USsXXbm9SpIE50KFl2n5Ao4rWjzLbsSW9XEtVN4Sp4WRpQ1taoq-pjpU1G0e2WXT0Xhrmr2HrX9IaNjssCRuLJxmGLTol06AberiVwV-fPISbRDtY5zQaeo11sVhfu0Gt93S0-Cwuu_onVaRPO-H_EDJYrp8yTdad0v1RfYpFiw5ZvraFFI9-72zaXklIi4_fr2Atv-dwZ31970dwffAqig_mYU3kh82_QO7f63IN8FmK9HHiSbcOLSleQeDdKaxN9ETG7enaWv2h-ix_teyWW5BNTJgUku9yaYbjbk9cXolH7JC9o4fleN_e-X_g_K_78m

Before screenshot:

image

After screenshot:

image

@Wires77 Wires77 added the bug: calculation Numerical differences label Oct 19, 2022
@Wires77 Wires77 force-pushed the fix_div_fist_of_war branch from c755841 to 2e64921 Compare October 19, 2022 18:49
QuickStick123
QuickStick123 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@QuickStick123 QuickStick123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wires77 Wires77 changed the title Fix div fist of war Fix Divergent Fist of War increasing Stun Threshold Oct 20, 2022
@Wires77 Wires77 merged commit 82cd19d into PathOfBuildingCommunity:dev Oct 20, 2022
@Wires77 Wires77 mentioned this pull request Dec 7, 2022
Merged
@Wires77 Wires77 deleted the fix_div_fist_of_war branch February 8, 2023 08:20
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuickStick123 QuickStick123 QuickStick123 approved these changes

Assignees
No one assigned
Labels
bug: calculation Numerical differences
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wires77 @QuickStick123