Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for some pobb.in links #5078

Merged

Conversation

Dullson
Copy link
Contributor

@Dullson Dullson commented Sep 14, 2022

Our current pob link matching pattern is not covering some pobb.in URLs.
This PR fixes the pattern to cover urlsafe base64 characters (used by pobb.in)

Following link is currently unloadable via the "Open" button on the page (using pob protocol link)
https://pobb.in/-bUISrt3agGa

@QuickStick123 QuickStick123 added the bug Something isn't working label Sep 19, 2022
Copy link
Contributor

@QuickStick123 QuickStick123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LocalIdentity LocalIdentity changed the title fix: pob protocol link parsing for pobb.in Fix parsing for some pobb.in links Dec 9, 2022
@LocalIdentity LocalIdentity merged commit 413a068 into PathOfBuildingCommunity:dev Dec 9, 2022
@Dullson Dullson deleted the fix_pob_link_parse branch December 10, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants