Improve handling of unscalable mods and fix some mods from alternate qualities not applying. #4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@Paliak why couldn't |
|
I looked at how purity of elements worked and applied that to the impurities. |
…dummy display stat. Re add entries in skillStatMap in case they're used by something.
…ding into auraunscalable
2 tasks
* Fix Up several other instances of this and add support for a couple aura mods while at it. * FIX: add a check in case (env.configInput["enemyCritChance"] ends up nil. Co-authored-by: Paliak <[email protected]>
Paliak
changed the title
Paliak
changed the title
|
Fixes #5031 |
LocalIdentity
approved these changes
Sep 14, 2022
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4848 #4849 #5031 #5042
Absorbed #5043.
This pr changes the way unscaled mods are handled and fixes related issues adding unscaled tag to a variety of mods. Also fixes some mods from alternate qualities not applying correctly and implements parsing for a few currently unhandled stats.
Before screenshot:
After screenshot: