Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add breakdown for Boneshatter self damage #4734

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Add breakdown for Boneshatter self damage #4734

merged 3 commits into from
Oct 17, 2022

Conversation

Lilylicious
Copy link
Contributor

@Lilylicious Lilylicious commented Aug 10, 2022 •
edited
Loading

Description of the problem being solved:

Adds a self damage breakdown to Boneshatter similar to Forbidden Rite. It takes into account all elements (phys taken as X), armour, resistances, fortify/berserk/etc.

Link to a build that showcases this PR: https://pobb.in/sQ4lIBXWfh6h

After screenshot:

image

@Lilylicious Lilylicious marked this pull request as draft August 10, 2022 22:41
@Lilylicious Lilylicious changed the title [WIP] Boneshatter self damage breakdown Boneshatter self damage breakdown Aug 10, 2022
@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 10, 2022
@Lilylicious Lilylicious force-pushed the boneshatter branch 3 times, most recently from 0b2b57e to f2f3d67 Compare August 11, 2022 08:11
@Lilylicious
Copy link
Contributor Author

This PR has some overlap with #4705 in the CalcDefence file.

@Lilylicious Lilylicious marked this pull request as ready for review August 11, 2022 10:25
@Lilylicious
Copy link
Contributor Author

Updated to work with #4673, but still has duplicated code from #4705.

@Lilylicious
Copy link
Contributor Author

No more duplicated code, ready to merge.

@QuickStick123
Copy link
Contributor

QuickStick123 commented Sep 7, 2022 •
edited
Loading

Fixes #3063 as all other issues are resolved

@QuickStick123 QuickStick123 mentioned this pull request Sep 24, 2022
Merged
Wires77
Wires77 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and Forbidden Rite seem like a great opportunity for breaking CalcDefence.lua up into a callable component so we don't have to worry about code duplication and maintenance headaches in the future.

@Wires77 Wires77 changed the title Boneshatter self damage breakdown Add breakdown for Boneshatter self damage Oct 17, 2022
@Wires77 Wires77 merged commit b967d61 into PathOfBuildingCommunity:dev Oct 17, 2022
@Wires77 Wires77 mentioned this pull request Oct 17, 2022
Closed
2 tasks
@Wires77 Wires77 mentioned this pull request Dec 7, 2022
Merged
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Regisle Regisle Regisle left review comments

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lilylicious @QuickStick123 @Wires77 @Regisle