-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve scaled modifier precision #4640
Merged
LocalIdentity
merged 8 commits into
PathOfBuildingCommunity:dev
from
Lothrik:high-precision-mod-wip
Aug 8, 2022
Merged
Improve scaled modifier precision #4640
LocalIdentity
merged 8 commits into
PathOfBuildingCommunity:dev
from
Lothrik:high-precision-mod-wip
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a fair bit of discussion going on in Discord regarding Evasion and Armour scaling and depending on the results of that the changes I made to |
This reverts commit 075dfcb.
Added high precision support for every base leech modifier type. |
This was
linked to
issues
Jul 25, 2022
LocalIdentity
approved these changes
Aug 8, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain modifiers were discarding their floating point values when being scaled by
ModStoreClass:ScaleAddMod
, leading to situations where things like+2% Critical Strike Chance
on a Bottled Faith flask would not be affected by modifiers to Flask Effect until you reached a breakpoint, causing it to jump to the next integer value (+3% Critical Strike Chance
in this example).This problem affects a wide variety of modifiers; currently this PR only applies this change to base
Critical Strike Chance
and baseLife Regen Percent
.This PR also addresses a minor display issue in the calcs breakdown where more modifiers (such as 25% more Evasion + 30% more Evasion) weren't displaying sufficiently high precision, leading to weird inconsistencies where one field would say you had63%
more Evasion, and another would display ax 1.62
more Evasion multiplier. This is purely a cosmetic change as later calculations always used the real value (not the inaccurate/formatted one).