Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix totems not being affected by auras #4636

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Jul 23, 2022

Fixes #4550 .

Description of the problem being solved:

Handle totems being affected by player auras and correct calculations for Forbidden right and Righteous Fire.

Link to a build that showcases this PR:

https://pobb.in/s9LAfsKONJuO

Before screenshot:

before

After screenshot:

after

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Jul 23, 2022
@Paliak Paliak marked this pull request as ready for review July 24, 2022 00:18
@Lothrik
Copy link
Contributor

Lothrik commented Aug 18, 2022

I came across this (while looking for something else) in the 3.13.0 patch notes and it definitively proves action speed is supposed to affect totems:
Fixed a bug where the action speed buff granted by the Greater Harbinger of Time from The Flow Untethered and The Torrent's Reclamation unique items did not affect your totems.

@Nostrademous
Copy link
Contributor

LGTM

@LocalIdentity LocalIdentity merged commit bf8c31b into PathOfBuildingCommunity:dev Sep 14, 2022
@Paliak Paliak deleted the totemAuraFix branch September 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Totems aren't affected by defensive auras in PoB
6 participants