Fix dps comparison not working correctly when using the saviour and using overrides #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4631 .
Description of the problem being solved:
Overrides were not propagating through the call to initEnv in copyActiveSkill which was causing issues with dps comparison. Fixing that issues caused dps comparison to only work correctly when an odd number of skills was selected for full fps due to flask toggles being applied multiple times to a single env instance because of caching in calcs.calcFullDPS. Toggling flasks only when a cached env is not present seems to resolve the issue.
Steps taken to verify a working solution: