Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain controls not require focus to display tooltips #4594

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Jul 14, 2022

#4441 was preventing item list tooltips under the items tab, the "save" button when editing item text, and gem select controls from displaying tooltips when they were not the currently focused control element.

This restores that behavior, as the noTooltip functionality (as far as I can tell, anyway) is not necessary to prevent overlapping tooltips for those specific controls.

There are a few other cases where similar changes might also be beneficial (such as the equipped items list), but I wasn't able to get those elements working with a forceTooltip option.

@LocalIdentity LocalIdentity added the user-interface Changes that only affect the UI label Jul 15, 2022
@LocalIdentity LocalIdentity merged commit 793e3ed into PathOfBuildingCommunity:dev Jul 15, 2022
@Lothrik Lothrik deleted the improve-skillstab branch July 15, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants