Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alternate quality dropdown options not changing on gem deletion #4532

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fix alternate quality dropdown options not changing on gem deletion #4532

merged 1 commit into from
Jul 11, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Jul 7, 2022

Fixes #2810 .

Description of the problem being solved:

See issue

Steps taken to verify a working solution:

  • Create a gem
  • Support it with alt quality gem
  • Support it with Awakened gem
  • Support it with alt quality gem
  • Delete first alt quality gem
  • Verify the only alt quality option for the awakened gem is "Default"
  • Verify the other alt quality gem has their normal alt quality options

@Wires77 Wires77 added the bug Something isn't working label Jul 7, 2022
@LocalIdentity LocalIdentity merged commit d098d1b into PathOfBuildingCommunity:dev Jul 11, 2022
@Wires77 Wires77 deleted the gem_deletion_alt_qual_reset branch February 8, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing gems from links breaks alt-quality listboxes
2 participants
@Wires77 @LocalIdentity