Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "% increased cast speed if a minion has been killed recently" #4464

Conversation

spawnie-no-oni
Copy link
Contributor

@spawnie-no-oni spawnie-no-oni commented Jun 16, 2022

Fixes #4455 .

Description of the problem being solved:

Ghastly Eye Jewel can have a mod that reads "d% increased cast speed if a minion has been killed recently". From in-game testing this seems to proc under exactly the same conditions as "if a minion died recently".

However, the mod does not get parsed by POB because we only look for the string "if a minion died recently". It is inconvenient because any build that relies on this jewels needs manually modify them each time they are imported to calculate their cast speed properly.

Steps taken to verify a working solution:

  • Create a new build
  • Path to a jewel socket
  • Create a custom item with the following stats
    Enthralling Leer
    Ghastly Eye Jewel
    Unique ID: 437aad3ec28997fc919c9d100102fb765eb5ca2a27b28d2bafa334010211790a
    Item Level: 74
    LevelReq: 28
    Implicits: 0
    +30 to maximum Life
    Minions have 12% increased maximum Life
    7% increased Cast Speed if a Minion has been Killed Recently
  • Socket it into the Jewel socket.
  • Below configuration, tick "has a minion died recently ?".
  • Add any spell skill to the build (in my case SRS)
  • Check that the cast speed is modified when allocating and deallocating the jewel.

Link to a build that showcases this PR:

https://pastebin.com/V7jw0HJH

Before screenshot:

image

After screenshot:

image

@LocalIdentity LocalIdentity added the bug: accuracy Wording differences label Jul 2, 2022
@LocalIdentity LocalIdentity changed the title Properly parse the Ghastly Eye Jewel mod "% increased cast speed if a minion has been killed recently" Add support for "% increased cast speed if a minion has been killed recently" Jul 2, 2022
@LocalIdentity LocalIdentity merged commit 5ff0439 into PathOfBuildingCommunity:dev Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ghastly Eye Jewels "% increased cast speed if a minion has been killed recently" mod is not applied properly
2 participants