Add support for "% increased cast speed if a minion has been killed recently" #4464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4455 .
Description of the problem being solved:
Ghastly Eye Jewel can have a mod that reads "d% increased cast speed if a minion has been killed recently". From in-game testing this seems to proc under exactly the same conditions as "if a minion died recently".
However, the mod does not get parsed by POB because we only look for the string "if a minion died recently". It is inconvenient because any build that relies on this jewels needs manually modify them each time they are imported to calculate their cast speed properly.
Steps taken to verify a working solution:
Enthralling Leer
Ghastly Eye Jewel
Unique ID: 437aad3ec28997fc919c9d100102fb765eb5ca2a27b28d2bafa334010211790a
Item Level: 74
LevelReq: 28
Implicits: 0
+30 to maximum Life
Minions have 12% increased maximum Life
7% increased Cast Speed if a Minion has been Killed Recently
Link to a build that showcases this PR:
https://pastebin.com/V7jw0HJH
Before screenshot:
After screenshot: