Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when loading build containing a newer tree #4386

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Fix crash when loading build containing a newer tree #4386

merged 1 commit into from
Jun 2, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented May 23, 2022 •
edited
Loading

To reproduce:

  1. Checkout an old version of PoB
  2. Try to load a current build (e.g. https://pastebin.com/fmCLSfnD )
  3. Notice crash because the build code exits early before initializing some dropdown values

This simply moves the initialization code before any of the savers trigger

@Wires77 Wires77 added the crash Causes PoB to crash and is High Priority label May 23, 2022
@Wires77 Wires77 mentioned this pull request May 30, 2022
Closed
2 tasks
@LocalIdentity LocalIdentity merged commit 7164226 into PathOfBuildingCommunity:dev Jun 2, 2022
@Wires77 Wires77 deleted the new_tree_crash branch February 8, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
crash Causes PoB to crash and is High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wires77 @LocalIdentity