Add mouse shortcuts to skills tab #4373
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to ease the tedium of enabling/disabling multiple skill groups typically found in build guide pobs and went a little further in the process.
This PR adds the following shortcuts to the skill list in Skills Tab:
Right Click
: enable/disable skill groupALT + Right Click
: include/exclude skill group in FullDPS calculationALT + Left Click
: select skill group as the main skillalso
[FullDPS]
and[Active]
tags are added to skill group labels to indicate their configurationsCurrent behavior
This is the current process when you want to switch between different skill sets, it requires a lot of clicks:
OAMXmQFHpe.mp4
Also, you have to hunt for enabled FullDPS boxes if you have multiple sets of the same skill since the left column display doesn't include any info other than the active skill name:
eC3zrsd2sC.mp4
Proposed functionality
27YIRkmkVZ.mp4
I was going to split this PR into two parts, one for enable/disable shortcut and another one for other functionality which comes with new tags but didn't want to clutter the repo with similar requests.
Toggling enable/disable already has an indicator (
(Disabled)
tag) so it is a visually non-invasive addition compared to the other two.Added tags look fine to me but I can see an argument being made for potential visual clutter. I considered adding background color to rows instead of tags but throwing around colors doesn't feel better.
Between two tags,
FullDPS
one feels mandatory with hotkey since there is no indicator for toggling this flag like enable/disable tag(Disabled)
.Active
tag is a helpful indicator in no label scenarios like this and provides instant feedback when main skill is changed via proposed alt+click shortcut but one can argue that it's not mandatory for shortcut function since main skill update on left panel is also visible.Overall, I think these features feel great whether you navigate a content creator's PoB with a skill section for every act or check numbers on the different combinations of curse-aura-skill setups.
All the styling and hotkey selection are done arbitrarily, let me know if you have any suggestions.