Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option for showing tooltips for all slots #4292

Merged
merged 1 commit into from
May 28, 2022

Conversation

deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Mar 17, 2022

Add "Show tooltips only for affected slots" configuration option that
will show tooltips only affected slot instead of all slots (this
significantly reduces clutter when viewing jewel sockets for example).

Signed-off-by: Tomas Slusny [email protected]

Without config enabled (current behaviour)

image

With config enabled:

image

Config window:

image

@deathbeam deathbeam force-pushed the config branch 3 times, most recently from 79869d3 to 6da216a Compare March 18, 2022 01:48
@deathbeam
Copy link
Contributor Author

deathbeam commented Mar 18, 2022

Also honestly this might even be better to be enabled by default because the tooltips get quite insane sometimes (or well, actually very often as soon as you enable full dps in builds or the builds are using like more than 2 mechancis).

EDIT:
Changed it to be enabled by default

Add "Show tooltips only for affected slots" configuration option that
will show tooltips only affected slot instead of all slots (this
significantly reduces clutter when viewing jewel sockets for example).

Signed-off-by: Tomas Slusny <[email protected]>
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for adding the config option too!

@Wires77 Wires77 merged commit a1509dd into PathOfBuildingCommunity:dev May 28, 2022
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request May 29, 2022
…ildingCommunity#4292)

Add "Show tooltips only for affected slots" configuration option that
will show tooltips only affected slot instead of all slots (this
significantly reduces clutter when viewing jewel sockets for example).

Signed-off-by: Tomas Slusny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants