Minor EHP improvments #4227
Merged
Minor EHP improvments #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basic support for enemy crit
For fairly obvious reasons, armour cannot mitigate more than 100% of incoming damage. Also removed an unnecessary NaN check as I cannot get the error it was intended to prevent to trigger under any conditions.
.. and explain what's happening briefly in the related tooltip.
This prevents nonsensical (negative) damage values and properly handles negative penetration.
fix merge issue
2 tasks
2 tasks
2 tasks
Wires77
approved these changes
Jun 3, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to EHP and other defence related things
improved ehp helper function
reducing the limit (to make it not slowdown as much), having it return "inf" if greater than limit, moving magic numbers to data.misc
shows life recoverable when applicable
add option to disable gain on block from applying to EHP calcs
fix negative max taken hit for transcendence with high max resistance and any enemy pen
other minor fixes